Mac/IE + JavaScript = Nightmare!

[mejust]

Hi all....

The following Javascript does not seem to work using IE on a MAC. The images do not display. Seems to work OK using Safari and all browsers on a PC.

The script creates a slideshow of images.

Any suggestions? Much appreciated!....

<script type="text/javascript"><!--
function GotoPic(Num){
location.href=location.pathname+'?'+Num;
}

N=-1;Picture=new Array;
N++;Picture[N]="imagename.jpg";
N++;Picture[N]="imagename2.jpg";
N++;Picture[N]="imagename3.jpg";
N++;Picture[N]="imagename4.jpg";

var ThisPic;
var PrevPic;
var NextPic;
var ShowPrev;
var ShowNext;

if (location.search){
ThisPic=location.search.substring(1)*1;
}else{
ThisPic=0;
}

NextPic=ThisPic+1;ShowNext=(NextPic>(Picture.lengt h-1)?false:true);
PrevPic=ThisPic-1;ShowPrev=(PrevPic<0?false:true);

if (ShowPrev){
document.writeln('<a href="javascript:GotoPic(PrevPic)"><img src="navigation/previous.jpg" width="75" height="23" border="0"></a><img src="navigation/blank.jpg"> ');
}
if (ShowNext){
document.writeln('<a href="javascript:GotoPic(NextPic)"><img src="navigation/next.jpg" width="37" height="23" border="0"></a> ');
}
document.write('</P><img src="'+Picture[ThisPic]+'">');
// -</script>

[mejust]

A live version of the site can be found here (in case this helps):

www.thorogood.net

And here is a page (one of many) using the script itself:

http://www.thorogood.net/royknipe_portfolio.htm

[Till]

Save yourself the hassle. It's pointless to make anything work in IE on MAC. IE is dead on the MAC, no longer being developed. The majority of users utilize Safari, and then Firefox, and then maybe Camino.

That is what "we" test with.

[mejust]

Problem is.... I sent the redesign to 31 illustrators (who appear on the site). Of those, 3 or more were unable to view that script. They were using IE/MAC. I think as the bulk of creatives (the sites target audience) use Macs the site will receive above average traffic from those using IE/MAC.

[Till]

Well, that's probably people with OS9 or others who are just nuts.

What error do you get from IE? A lot of JavaScript is not even implemented on it. Just make sure you test your objects before you use them.

For example, assuming "location.href" to be there, is not a good idea. IMO, it should be "window.location.href" anyway. And so on, and so on.

[mejust]

To be honest, I am not a developer. I asked around on the JavaScript forums (googled etc) to find that script in the 1st place (I did not write it).

Re: Error msgs

I selected 'display errors' within the settings of IE on the Mac but when I visit/load the page - no error msg is displayed from what I can see. I do not use that browser (ever) so perhaps I am looking in the wrong place.

[Till]

Try to substitute the location part then wherever it occurs, and check if it still works.

Old:

location.href=location.pathname+'?'+Num;

New:

window.location.href=window.location.pathname+'?'+Num;

[mejust]

Thanks! Really appreciate your help.
I made the changes and uploaded a test page:

http://www.thorogood.net/testing/till.htm

Still nothing in IE/MAC. No error msg pops up (i discovered thats how it alerts you).

[Till]

Fix this:

// -</script>

With:

//-->
</script>

Also:

<script type="text/javascript">

With this:

<script language="JavaScript" type="text/javascript">

(Maybe you even need a version-attribute for IE?)

Also, regarding general JavaScript code, this is how you initialize a variable:

var N = 0; // integer, not a string :-)

I am not sure if there is anything else missing, maybe it's even more picky. The code doesn't look like it's too much ahead of IE.

[mejust]

You did it!!!!!

Thank you so much for your help! I will go and rework all 31 pages now... fun fun fun! :-)

Much appreciated. You are a star.




Your working edit:

www.thorogood.net/testing/till.htm

[Till]

Originally Posted by mejust

You are a star.

Pleasure!